fix: revert "attach milestone if release build" #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd-aliem
force-pushed
the
revert-milestone
branch
from
acdfd99 to
d70cd99
Compare
This reverts commit e83e248. Signed-off-by: Amanda Liem <[email protected]>
Signed-off-by: Amanda Liem <[email protected]>
npmccallum
force-pushed
the
revert-milestone
branch
from
d70cd99 to
0ee27de
Compare
DGonzalezVillal
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e83e248, and moves to the new certificate milestone names prepended with
c.As discussed w/ team last week, we decided to re-enable attaching milestones in all builds.
This means that the
develtag image assets (rebuilt upon every push to main) will always support attaching milestones to issues if the appropriate tests pass.Note that the user running the tests must have editor access to the repository where they're opening the issue - otherwise the milestone field will be silently ignored by github.
New certificate name is hardcoded to
c3.0.0-0while versioning architecture is discussed.