-
Notifications
You must be signed in to change notification settings - Fork 6
docs: dispatch proxy handling #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Amanda Liem <[email protected]>
DGonzalezVillal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks
| ``` | ||
|
|
||
| If you run the first command with no filter specified, you should see the following screen: | ||
| If you run the first command with no filter specified, you should see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you run the first command with no filter specified, you should see the | |
| If you run the first command with no filter specified, you see all of the current images being hosted in the disptach release: |
I'm not sure if this is the perfect wording, but I wouldn't tell them they are getting the exact same screen, since it could change every time we change the available images. For example, it is already outdated
|
|
||
| While this screen is up, the images specified are queued for testing. Each image has an status icon to the left of its name. See [Workflow-Stats](https://github.com/AMDEPYC/dispatch?tab=readme-ov-file#workflow-states) for a table of the icon meanings. Pressing q will kill the dispatch process. | ||
| While this screen is up, the images specified are queued for testing. Each image | ||
| has an status icon to the left of its name. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| has an status icon to the left of its name. See | |
| has a status icon to the left of its name. See |
| web browser flow as a user that has the accesses listed above. | ||
| ``` | ||
| gh auth login -h github.com -w -p https |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the command you would run to log in directly with the web-browser? Context on what this command does might be helpful
Break out GH permissions into another section and then create a section for proxy handling. Handling AMDEPYC/dispatch#17.