Skip to content

Conversation

@amd-aliem
Copy link
Contributor

Break out GH permissions into another section and then create a section for proxy handling. Handling AMDEPYC/dispatch#17.

@amd-aliem amd-aliem enabled auto-merge (rebase) December 16, 2025 19:20
Copy link
Contributor

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks

```

If you run the first command with no filter specified, you should see the following screen:
If you run the first command with no filter specified, you should see the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you run the first command with no filter specified, you should see the
If you run the first command with no filter specified, you see all of the current images being hosted in the disptach release:

I'm not sure if this is the perfect wording, but I wouldn't tell them they are getting the exact same screen, since it could change every time we change the available images. For example, it is already outdated


While this screen is up, the images specified are queued for testing. Each image has an status icon to the left of its name. See [Workflow-Stats](https://github.com/AMDEPYC/dispatch?tab=readme-ov-file#workflow-states) for a table of the icon meanings. Pressing q will kill the dispatch process.
While this screen is up, the images specified are queued for testing. Each image
has an status icon to the left of its name. See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
has an status icon to the left of its name. See
has a status icon to the left of its name. See

web browser flow as a user that has the accesses listed above.
```
gh auth login -h github.com -w -p https
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the command you would run to log in directly with the web-browser? Context on what this command does might be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants