refactor: make image directories hierarchical #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the image directory structure into a hierarchical layout. The changes update the image paths in both the README command examples and the GitHub Actions workflow configuration.
- Updated image paths in the README command examples.
- Adjusted image names in the matrix of the build workflow to reflect the hierarchical directory structure.
Reviewed Changes
Copilot reviewed 11 out of 18 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated command examples with the new hierarchical image paths. |
| .github/workflows/build.yml | Revised matrix image names to match the hierarchical directory refactoring. |
Files not reviewed (7)
- guest-fedora-41/mkosi.conf: Language not supported
- guest/debian/bookworm/mkosi.conf: Language not supported
- guest/debian/mkosi.conf: Language not supported
- guest/fedora/41/mkosi.conf: Language not supported
- guest/fedora/mkosi.conf: Language not supported
- guest/ubuntu/mkosi.conf: Language not supported
- guest/ubuntu/oracular/mkosi.conf: Language not supported
Comments suppressed due to low confidence (2)
README.md:21
- Ensure that the updated hierarchical image path is fully aligned with corresponding documentation and directory structures elsewhere in the project.
-kernel guest/fedora/41/image.efi \
.github/workflows/build.yml:11
- Verify that the new matrix image name fits with the hierarchical directory naming convention established in the refactor and is consistent across all related configuration files.
- guest/fedora/41
npmccallum
force-pushed
the
hier
branch
5 times, most recently
from
0217e46 to
a065118
Compare
Collaborator
Author
|
@LakshmiSaiHarika Can you review? |
Contributor
|
Looks good to me ! |
Collaborator
Author
|
@LakshmiSaiHarika Are you able to do a github review? Or do you not have permissions? |
LakshmiSaiHarika
approved these changes
Apr 30, 2025
Contributor
LakshmiSaiHarika
left a comment
LakshmiSaiHarika
left a comment
There was a problem hiding this comment.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.