Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slope limiting to corner of cell, not fine cell next to corner of cell #4383

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

sw561
Copy link
Contributor

@sw561 sw561 commented Mar 20, 2025

Summary

Proposed change to illustrate the issue being described in #4382
Slope limiting is based on value in the fine cell (and thus dependent on refinement ratio) instead of the corner of the cell.

Additional background

See issue #4382

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Copy link
Member

I am reluctant to accept the changes. It might affect a lot of codes with unknown consequences. Maybe we could add a new option for this instead of replacing the current behavior.

@asalmgren
Copy link
Member

Also -- imagine a bilinear function -- the slope should be limited in that case by the fine corner ghost cell, not the corner of the cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants