AMReX Enum: Underlying Value #4616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes one needs the underlying (u)int type of an enum, e.g., when building bitmasks. This adds a helper function to `AMREX_ENUM`.
ax3l
force-pushed
the
topic-enum-underlying
branch
from
929e83f to
dbc02ed
Compare
ax3l
commented
Aug 18, 2025
Comment on lines
+136
to
+141
| template <typename T, typename ET = amrex_enum_traits<T>, | ||
| std::enable_if_t<ET::value,int> = 0> | ||
| constexpr auto getEnumUnderlyingValue (T v) noexcept | ||
| { | ||
| return static_cast<std::underlying_type_t<T>>(v); | ||
| } |
There was a problem hiding this comment.
I can make T also an int, because we hard-code int in AMREX_ENUM for now. Let me know what you prefer.
There was a problem hiding this comment.
https://en.cppreference.com/w/cpp/utility/to_underlying.html We could also use a name that is similar to the future C++ standard, like toUnderlying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes one needs the underlying (u)int value of an
enum class, e.g., when building bitmasks. This adds a helper function toAMREX_ENUM.Additional background
BLAST-ImpactX/impactx#1104
Checklist
The proposed changes: