Skip to content

Fix test_13 in relation to IS-07 senders #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristian-recoseanu merged 6 commits into from
Jan 7, 2026
Merged

Fix test_13 in relation to IS-07 senders #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4db2818
Fix test_13 in relation to IS-07 senders/receivers
cristian-recoseanu Nov 28, 2025
63ff535
Fix lint issues
cristian-recoseanu Nov 28, 2025
f6bd8f4
Combine get_valid_transports_with_transport_file with the existing ge…
cristian-recoseanu Dec 5, 2025
a1f8732
Update nmostesting/IS05Utils.py
cristian-recoseanu Dec 5, 2025
d7681a6
Correct flag value
cristian-recoseanu Dec 5, 2025
b98290e
Rename argument to "include_transports_without_transport_file"
cristian-recoseanu Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nmostesting/IS05Utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ class IS05Utils(NMOSUtils):
def __init__(self, url):
NMOSUtils.__init__(self, url)

def get_valid_transports(self, api_version):
def get_valid_transports(self, api_version, include_transports_without_transport_file=True):
"""Identify the valid transport types for a given version of IS-05"""
valid_transports = ["urn:x-nmos:transport:rtp",
"urn:x-nmos:transport:rtp.mcast",
"urn:x-nmos:transport:rtp.ucast",
"urn:x-nmos:transport:dash"]
if self.compare_api_version(api_version, "v1.1") >= 0:
if self.compare_api_version(api_version, "v1.1") >= 0 and include_transports_without_transport_file:
valid_transports.append("urn:x-nmos:transport:websocket")
valid_transports.append("urn:x-nmos:transport:mqtt")
return valid_transports
Expand Down
3 changes: 2 additions & 1 deletion nmostesting/suites/IS0502Test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,8 @@ def test_13(self, test):
return test.FAIL(result)

try:
valid_transports = self.is05_utils.get_valid_transports(self.apis[CONN_API_KEY]["version"])
valid_transports = self.is05_utils.get_valid_transports(
self.apis[CONN_API_KEY]["version"], include_transports_without_transport_file=False)

access_error = False

Expand Down