Skip to content

Commit

Permalink
Migrate eigen3 to MODULE.bazel.
Browse files Browse the repository at this point in the history
  - Pull from https://registry.bazel.build/modules/eigen.
  - The previous `WORKSPACE` commit hash matches [eigen 3.4](https://gitlab.com/libeigen/eigen/-/tree/3147391d946bb4b6c68edd901f2add6ac1f31f8c); intentionally port while keeping the same version.

PiperOrigin-RevId: 725207738
  • Loading branch information
jwcullen committed Feb 10, 2025
1 parent a42466a commit 758fd33
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 10 deletions.
4 changes: 4 additions & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ bazel_dep(
version = "1.8.5",
repo_name = "com_google_benchmark",
)
bazel_dep(
name = "eigen",
version = "3.4.0",
)
8 changes: 0 additions & 8 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,3 @@ git_repository(
commit = "82ac57d9f1aaf575800cf17373348e45b7ce6c0d",
remote = "https://gitlab.xiph.org/xiph/opus.git",
)

# Eigen.
git_repository(
name = "eigen3",
build_file = "eigen.BUILD",
commit = "3147391d946bb4b6c68edd901f2add6ac1f31f8c",
remote = "https://gitlab.com/libeigen/eigen.git",
)
2 changes: 1 addition & 1 deletion iamf/cli/adm_to_user_metadata/adm/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ cc_library(
"@com_google_absl//absl/strings",
"@com_google_absl//absl/strings:str_format",
"@com_google_audio_to_tactile//:dsp",
"@eigen3",
"@eigen",
],
)

Expand Down
2 changes: 1 addition & 1 deletion iamf/cli/ambisonic_encoder/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ cc_library(
":associated_legendre_polynomials_generator",
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/log:check",
"@eigen3",
"@eigen",
],
)

Expand Down

0 comments on commit 758fd33

Please sign in to comment.