Skip to content

fix: open external links in new tab for desktop and mobile navigation #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zahnentferner merged 1 commit into from
Mar 12, 2026
Merged

fix: open external links in new tab for desktop and mobile navigation #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/shared/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ function MoonIcon(props) {
function MobileNavItem({ href, children }) {
return (
<li>
<Popover.Button as={Link} href={href} className="block py-2">
<Popover.Button
as={Link}
href={href}
target={href.startsWith('http') ? '_blank' : undefined}
rel={href.startsWith('http') ? 'noopener noreferrer' : undefined}
className="block py-2"
>
{children}
</Popover.Button>
</li>
Expand Down Expand Up @@ -144,6 +150,8 @@ function NavItem({ href, children }) {
<li>
<Link
href={href}
target={href.startsWith('http') ? '_blank' : undefined}
rel={href.startsWith('http') ? 'noopener noreferrer' : undefined}
className={clsx(
'relative block px-3 py-2 transition',
isActive
Expand Down