fix: Ensure deterministic and safe project sorting to prevent hydration issues#695
fix: Ensure deterministic and safe project sorting to prevent hydration issues#695AnshuPriya-1 wants to merge 1 commit intoAOSSIE-Org:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced inline sorting in the Projects page render with a precomputed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey, |
aa28f12 to
e8f34e3
Compare
|
Hii @Aditya30ag |
Addressed Issues:
Fixes #663
Description
This PR ensures deterministic and safe sorting of projects on the
/projectspage to prevent potential hydration mismatches.Changes
sortedProjectsvariable for stable sortinglocaleComparewith{ sensitivity: 'base' }for case-insensitive sorting(a.name || ''))Motivation
Although the hydration issue was previously resolved upstream, this change adds an additional safeguard to ensure:
Result
Screenshots/Recordings:
No UI changes. This PR focuses on improving internal rendering consistency and preventing potential hydration mismatches.
Additional Notes:
This change is a preventive improvement to ensure consistent behavior between server-side and client-side rendering, especially in cases where project names may vary in casing or be undefined.
Checklist
Summary by CodeRabbit
Bug Fixes
Updates