fix: ensure all external social links open in new tab with proper security attributes.#705
fix: ensure all external social links open in new tab with proper security attributes.#705TarequeSyed wants to merge 2 commits intoAOSSIE-Org:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request adds security attributes to external links across two files. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Addressed Issues:
Fixes #702
Screenshots/Recordings:
Not applicable (minor UI behavior fix)
Additional Notes:
Fixed inconsistent behavior in social media links.
The hero section links (e.g., YouTube) were opening in the same tab due to missing
target="_blank".Added
target="_blank"andrel="noopener noreferrer"to all the social media handles icons to ensure:Tested locally and verified that all external links now open in a new tab.
AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
☑︎] This PR does not contain AI-generated code at all.
[ ] This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.
I have used the following AI models and tools: None
Checklist
☑︎ My PR addresses a single issue, fixes a single bug or makes a single improvement.
☑︎ My code follows the project's code style and conventions
[ ] If applicable, I have made corresponding changes or additions to the documentation
[ ] If applicable, I have made corresponding changes or additions to tests
☑︎ My changes generate no new warnings or errors
☑︎ I have joined the Discord server and I will share a link to this PR with the project maintainers there
☑︎ I have read the Contribution Guidelines
☑︎ Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
☑︎ I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.
Summary by CodeRabbit