-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed notices in Grid/Column/Column #1047
base: master
Are you sure you want to change the base?
Conversation
Fixed notice: Trying to access array offset on value of type null at Grid/Column/Column.php:531
Very usefull! 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me @romainguerrero
It seems to be good but I suspect that's "hiding" some kind of other issue that should be investigated. As |
@DonCallisto I agree with you. The source code shows that To be completly safe, I guess that $this->data = ['operator' => $this->getDefaultOperator(), 'from' => static::DEFAULT_VALUE, 'to' => static::DEFAULT_VALUE]; but I don't know if creates side effects somewhere else. |
Any news on this? |
Any updates on this? As @vialcollet says, this is broken on dev environment for php 7.4 |
yes, you can find he required changes here: |
Thanks for repply! There is another aditional change than blocks.twig? |
Yes, it supports symphony 5.2 |
`{% set op = column.data.operator is defined ? column.data.operator : column.defaultOperator %}` call directly Column::getData(). Related to APY#1047 but not fixed
Fixed notice: "Trying to access array offset on value of type null" in Grid/Column/Column.php on PHP 7.4