Wrap function overload + closure + input wrappers + return type in a single packet #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls function object, overload, and closure info to create a class representing the packet of info the compiler needs in order to perform the compilation. Also moves TypeOf within init to avoid circular imports, and removes some redundant lambdas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Separates the responsibilities of the code parcel that is input to the compiler and the compiler itself - the unit of compilation is 'one overload + all the data the compiler needs to do its job' and by passing this in as a class we can clarify the role of python_to_native_converter (and runtime).
Down the line, this lets us contemplate synthetic compiler inputs that didn't come via entrypoint, & getting rid of convertTypedFunctionCall entirely and adjusting the convert() function to accept this packet directly.
Types of changes
Checklist: