Skip to content

Add function complexities and intermediates to cache #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: will-compiler-cache-partial-load-multi-module
Choose a base branch
from

Conversation

wllgrnt
Copy link

@wllgrnt wllgrnt commented Mar 2, 2023

NB: depends on #440.

Motivation and Context

In order to inline cached functions we must store the native and llvm layer intermediates, along with the complexities. This will reduce cache load time but should increase compiled function speed and predictability.

Approach

The optimal approach would be to regenerate the necessary intermediates from the information given at the native layer, but as it stands i don't think we don't have enough information to do so. So instead we track the necessary intermediates in the BinarySharedObject which gets read/written to disk.

How Has This Been Tested?

full pytest suite, debugging statements (now removed) to ensure the correct codepath is hit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

In order to inline cached functions we must store the native and llvm
layer intermediates, along with the complexities. This will reduce cache
load time but should increase compiled function speed and
predictability.
@wllgrnt wllgrnt force-pushed the will-inline-cached-functions branch from a135084 to 39dcf7c Compare March 3, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant