add conv optimizations #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nSircombe
requested changes
Nov 26, 2025
Contributor
nSircombe
left a comment
nSircombe
left a comment
There was a problem hiding this comment.
Could you add a line to the 'added' subheading in the [unreleased] section of the CHANGELOG.md
Ryo-not-rio
force-pushed
the
add-conv
branch
3 times, most recently
from
2051452 to
1a0b556
Compare
Ryo-not-rio
force-pushed
the
add-conv
branch
from
1a0b556 to
a6edcbf
Compare
| apply-github-patch uxlfoundation/oneDNN 8bdff1a2a6625432701363185a9bd34f7c22f241 | ||
| # https://github.com/uxlfoundation/oneDNN/pull/4377 - cpu: aarch64: conv: optimize brgemm | ||
| apply-github-patch uxlfoundation/oneDNN 93b8cc29afc6ee9c2856436a5f5b10d5f1f2f2f1 | ||
|
|
Contributor
There was a problem hiding this comment.
Admittedly I'm being a bit pedantic here but is there any chance we could remove this trailing blank line? Then I'm happy to approve
Ryo-not-rio
force-pushed
the
add-conv
branch
from
a6edcbf to
a55bfc5
Compare
puneetmatharu
approved these changes
Nov 27, 2025
nSircombe
approved these changes
Dec 2, 2025
Contributor
nSircombe
left a comment
nSircombe
left a comment
There was a problem hiding this comment.
looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.