-
Notifications
You must be signed in to change notification settings - Fork 1
[46] parallel filesystem convention example #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomStrepsil
wants to merge
46
commits into
ASOS:main
Choose a base branch
from
TomStrepsil:issue/46-parallel-filesystem-convention-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[46] parallel filesystem convention example #59
TomStrepsil
wants to merge
46
commits into
ASOS:main
from
TomStrepsil:issue/46-parallel-filesystem-convention-example
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <[email protected]>
Co-authored-by: Tom Pereira <[email protected]>
move reducer replacement to a provider, rather than a toggle side-effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #46
Details
Provide an example, within the expressjs harness, demonstrating a filesystem convention (enabled by #54) whereby features exist as parallel filesystems that "patch" modules on the mainline.
Include variations of:
objectProxyTogglePointusing an Proxy to retarget access to appropriate variations at access-timereact-pointcutspackagegetReducerMapfactory function as the control...to demonstrate potential toggle point configuration for these. The README.md for the example explains further.
To demonstrate the use of
valtio(previously only mentioned in passing in the features package docs), this is used to make a reactive features store on the browser.Scout Rule
unstable_config_lookup_from_filetov10_config_lookup_from_filenow that its stable awaiting next major version.@playwright/testto 1.56.0Screenshots
3x button click:

change to "feature 1":

2x button click:

change to "feature 2":

click "⛓️💥"

change to "feature 3":

4x button click:

change to "feature 4":

reload, with "feature2" header, then change to "feature 5":

CheckList
main.