Add Host Constraint, Fix issues with Task Lost and Offer Management #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itsoksarvesh
commented
Sep 16, 2025
itsoksarvesh
commented
- ADD: GPU Allocation Option in Mesos. Can still use GPU's on the host but will not be allocated in mesos.
- ADD/FIX: TASK_LOST Update causes TASKS to be killed
- FIX: Unwanted Decline Offer causing duplicate declines removed
- ADD: Host constraint: Option to only accept/request offers from particular hosts.
- FIX: Continously accepting offers when no task running.
…into AVENTER-UG-master
| if offerret.GetHostname() != "" { | ||
| offerIds = e.removeOffer(offerIds, offerret.GetId().GetValue()) | ||
| } | ||
| e.Mesos.Call(e.Mesos.DeclineOffer(offerIds)) |
There was a problem hiding this comment.
Why should it be removed?
There was a problem hiding this comment.
The unwanted offers were being declined twice .. Once in here and the other when these offerIds were returned to the HandleOffers function at the end to decline the unneeded offers ..This caused errors in mesos saying offer already declined
There was a problem hiding this comment.
Right, but there are two cases where the outside decline (line 81) does not catch. Both of them are errors. So maybe it makes more sense to keep decline (line 160) and remove the one in line 81? What do you think?
…iour on TASK_LOST status from Mesos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.