Skip to content

Fix segfault in avs_consume_quotable_token() #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix segfault in avs_consume_quotable_token() #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/utils/avs_token.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ void avs_consume_quotable_token(const char **src,

if (dest_size == 0) {
dest = NULL;
} else if (!dest) {
dest_size = 0;
Copy link

@Mierunski Mierunski Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having null dest pointer with non-zero dest_size looks more like a programming error. It should fire an assertion or error log message

}
for (char value; (value = **src); ++*src) {
if (value == '"') {
Expand Down