Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Opt.when method" #566

Closed
wants to merge 1 commit into from
Closed

Conversation

halotukozak
Copy link
Member

Reverts #560

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@halotukozak
Copy link
Member Author

The proposed addition of the methods to the Opt class has raised several concerns among the team. Firstly, there's uncertainty about its necessity and usefulness within the codebase. The method's purpose, which appears to be similar to existing methods like Task.when and Option.when, is questioned, as it introduces redundancy without clear benefits.

Moreover, there are doubts about the clarity and readability of the proposed method. The names may not accurately convey its functionality, potentially leading to confusion for developers working with the code. Additionally, concerns are raised about the method's impact on code execution efficiency, particularly regarding lazy evaluation and performance overhead.

Overall, the consensus emerges that the proposed addition does not address a significant problem or offer substantial improvements to the codebase. Therefore, there's a sentiment that investing time and effort into implementing and maintaining this feature may not be justified, leading to the decision to revert the change.

@halotukozak halotukozak requested a review from ddworak April 16, 2024 13:15
@ddworak
Copy link
Member

ddworak commented Apr 18, 2024

I'm okay (just as I was when accepting the original PR) with the current shape of this rather innocent extension method for Opt. Unless an actual improvement proposal is submitted, I don't see any benefit in merging this.

@ddworak ddworak closed this Apr 18, 2024
@ddworak ddworak deleted the revert-560-opt-when branch April 18, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants