refactor: Rename src directory to root_painter_trainer - #176
Closed
jakob1379 wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the PR. I see the motivation for renaming src/, and it might make sense as part of a broader refactor or packaging improvement. But right now, I'm not planning any major structural changes, and I don’t want to introduce changes unless I fully understand the benefits to users and maintainability myself. Renaming this folder may require updating docs, the Colab notebooks (linked in the main README), and probably the packaging setup? I’m not personally confident all the knock-on effects are accounted for yet. Perhaps we should chat at some point about the overall goals with your changes, and maybe we could work together on a more concrete proposal or roadmap for where this is heading, but for now I’d prefer to hold off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the python module
srctoroot_painter_trainer. This allows build systems to pick up the package automatically.Key Changes:
• Package Layout: The source code has been moved from
srcdirectory to a top-levelroot_painter_trainerpackage directory. This is a common simplification for Python packaging.• Configuration Update:
trainer/pyproject.tomlhas been updated to reflect the new package structure by removing thepackage-dirsetting. Thereadmehas also been corrected toREADME.txt.This is also in compliance with PEP8 (style guide) and PEP420 (Implicit Namespace Packages)