Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module Talent #177

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

PuppiizSunniiz
Copy link
Contributor

@PuppiizSunniiz PuppiizSunniiz commented Aug 22, 2023

Add Module Talent

chara-detail.js

  • Function
    • add new function by modify from existing function
      • GetModuleTalent (L:4195-4281) > modify from GetTalent call at L:2132)
      • ModuleTalentParse (L:4283-4355)> modify from TalentParse2
      • ModuleTalentShow (L:4357-4372)> modify from TalentShow
  • Var
    • battle_equipEN (L:32) > official module talent EN desc
    • TempModuletalentsTL (L:69) > dict for CN only mod
    • ModuletalentValue (L:104&2036) > temp array for last active potential talent tab

TempModuletalentsTL.json

  • New TL json for CN only module

Fixed

chara-detail.js

  • fixed certain ops show talent range on mod trait section (L:2126-2127)
    • Magallan (SUM-X)
    • Flamebringer (DRE-Y)
    • Bison (PRO-X)
    • Kal'tsit (PHY-X)
    • Siege (SOL-Y)
  • fixed some ops with unreadable stat (cant read if more than 2) by adding style white-space:initial in L:2147 & 2168 to make stat container warp

tl-attacktype.json

  • fixed < and > got eaten by HTML (L:511&515)
  • add TL for remaining CN only archetype&module trait
    • Archetype trait
      • Terra Research Commission (Flinger) (L:561-565)
      • U-Official (Bard) (L:566-569)
      • Friston-3 (Protector) (L:570-573)
      • Ritualist (L:622-625)
    • Module trait
      • Phalanx Caster : PLX-X (L:574-577)
      • Blast Caster : BLA-X (L:578-581)
      • Centurion : CEN-X (L:582-585) & CEN-Y (L:586-589)
      • Hellagur (Musha) : MUS-Y (L:590-593)
      • Push Stroker : PUS-X (L:594-597) & PUS-Y (L:598-601)
      • Trapmaster : TRP-X (L:602-605)
      • Geek : GEE-X (L:606-609)
      • Hexer : UMD-X (L:610-613)
      • Artificer : CRA-X (L:614-617)
      • Standard Bearer : BEA-X (L:618-621)

Known Issue

  • from gamedata json there some ops mod that have talent upgraded but value got add in trait blackboard instead of talent blackboard e.g. Carnelian mod x (gonna ignore this)

@Aceship
Copy link
Owner

Aceship commented Aug 24, 2023

speaking of module talent TL , iirc there's already tl of it but i havent converted it to json, probably i'll check later on after finished playing ac6 and starfield at this point probably

the format should looks like usual talent but ngl i havent touched it like years

thanks for hard work 👍

@PuppiizSunniiz
Copy link
Contributor Author

PuppiizSunniiz commented Sep 5, 2023

json\tl-attacktype.json

Add

  • Add Hunter trait TL (L:626-629)
  • Add Abjurer mod trait TL (L:630-633)

json\TempModuletalentsTL.json

Add

  • Add Jester patch Module talent TL
    • Ch'en : SWO-Y (L:1118-1139)
    • Saga : SOL-X (L:1140-1153)
    • Almond : HOK-X (L:1154-1175)
    • Silence the Paradigmatic : BLS-X (L:1176-1197)
    • Tsukinogi : BLS-X (L:1198-1219)
    • Nine-Colored : BLS-X (L:Deer 1220-1233)
    • Quercus : BLS-X (L:1234-1255)

@PuppiizSunniiz PuppiizSunniiz changed the title Add Module Talent - Add ModTL later Add Module Talent Sep 23, 2023
@PuppiizSunniiz
Copy link
Contributor Author

json\tl-attacktype.json

Add

  • Add Ebenholz 3rd Mod (MSC-D) trait TL (L:634-636)

json\TempModuletalentsTL.json

Add

  • Horn : FOR-X (L:1256-1277)
  • Ashlock : FOR-X (L:1278-1299)
  • Firewhistle : FOR-X (L:1300-1321)
  • Delphine : MSC-Y (L:1322-1343)
  • Verdant : PUM-Y (L:1344-1365)
  • Fiammetta : ART-X (L:1366-1378)
  • Ebenholz : MSC-D (L:1379-1400)

@PuppiizSunniiz
Copy link
Contributor Author

json\tl-attacktype.json

Add

  • Juggernaut Mod (UNY-X ) trait TL (L:637-641)
  • Primal Caster Archetype trait TL (L:642-645)
  • Loopshooter trait TL (L:646-649)

json\TempModuletalentsTL.json

Add

  • Mudrock : UNY-X (L:1400-1421)
  • Penance : UNY-X (L:1422-1443)
  • Vulcan: UNY-X (L:1444-1465)
  • Lessing : DRE-X (L:1466-1487)
  • Bassline : GUA-Y (L:1488-1502)
  • Nearl the Radiant Knight : DRE-Y (L:1503-1516)
  • Bagpipe : CHG-Y (L:1517-1538)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants