Update ci#138
Closed
RTnhN wants to merge 2 commits into
Closed
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ecb6e2b in 8 seconds
More details
- Looked at
41lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/build.yml:32
- Draft comment:
Ensure thatactions/upload-artifact@v4is compatible with your current workflow setup, as major version updates might introduce breaking changes. - Reason this comment was not posted:
Confidence changes required:50%
The update fromactions/upload-artifact@v2-previewtoactions/upload-artifact@v4is a good practice as it ensures the use of the latest features and security updates. However, it's important to verify that the new version is compatible with the existing workflow configuration.
Workflow ID: wflow_bb7zyAriQYtXcv2E
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updated CI workflow and documentation for new importers and watchers.
Key points:
.github/workflows/build.ymlto useactions/upload-artifact@v4instead ofv2-preview.rtnhn/aw-importer-lastfmandrtnhn/aw-importer-lifecycletosrc/importers.rstfor importing Last.fm and Lifecycle app data.RTnhN/aw-watcher-buttonstosrc/watchers.rstfor tracking external hardware buttons.Generated with ❤️ by ellipsis.dev