-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embroider: Port to v2 format: part 2: separate docs-app #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
873e280
to
6c80979
Compare
This was referenced Jan 10, 2025
mixonic
approved these changes
Jan 10, 2025
Not a blocker, but I am curious how we can more consistently leverage Addepar's own linting/style defaults in this kind of codebase without it being a headache. |
3e2e107
to
7017336
Compare
Yeah -- I don't have a great answer here. I suppose an addepar-specific eslint plugin seems like it would be a good initial step. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #61. This adds a new pkg to the monorepo: the docs app, following the embroider guide section here: https://github.com/embroider-build/embroider/blob/main/docs/porting-addons-to-v2.md#part-2-optional-split-docs-from-tests
I'm opening for review. This is best reviewed by looking at the relative diff to #61: bantic/embroider-native...bantic/embroider-native-v2-docs-app
I'll rebase it after #61 is merged.
The tldr:
assert.ok
->assert.true
, changeassert.equal
->assert.strictEqual
. And in one case change an assertion that was called from a conditional to be called uncondtionally