Skip to content

Certificate Improvements #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 21, 2024
Merged

Certificate Improvements #16

merged 8 commits into from
Nov 21, 2024

Conversation

@StefanGreve
Copy link
Member

@StefanGreve StefanGreve commented Nov 17, 2024 •
edited
Loading

  • Update dependencies
  • Remove hard-coded section requirements in DI methods
  • Add helper method for parsing information form certificate issuer
  • Add DependencyInjection test folder in test project
  • Use Assert.Multiple for multiple asserts, and add doc strings to test methods

@StefanGreve
Update dependencies
c90eb40
@StefanGreve
Remove hard-coded section paths in DI hookup methods
b3c9cb0
@StefanGreve
Add doc strings to options and DI methods.
3b05b8c 
* Use the TryAddOptions methods from AdvancedSystems.Core to bind
  options only once atomically.
* Add doc strings to Sections, and change type from struct to partial
  class.
* Change options type from struct to sealed record.
* Change internal modifier to private in DI methods.
@StefanGreve StefanGreve added the enhancement New feature or request label Nov 17, 2024
@StefanGreve StefanGreve added this to the Version 8.0.0-alpha milestone Nov 17, 2024
@StefanGreve StefanGreve self-assigned this Nov 17, 2024
@StefanGreve StefanGreve marked this pull request as ready for review November 19, 2024 22:38
@StefanGreve StefanGreve merged commit cfe6824 into master Nov 21, 2024
5 checks passed
@StefanGreve StefanGreve deleted the certificate branch November 21, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@StefanGreve StefanGreve

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 8.0.0-alpha

Development

Successfully merging this pull request may close these issues.

2 participants

@StefanGreve