Module Refactoring #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanGreve
force-pushed
the
module-refactoring
branch
from
abeb2d3 to
1268663
Compare
StefanGreve
commented
Dec 1, 2024
| $QueryBuilder.Add("UPDATE TodoList SET ") | ||
|
|
||
| if ($Project) { | ||
| $QueryBuilder.Add("Project = '${Project}'$(if ($Description -or $Priority -or $Status -or $DueDate) {','} else {''})") | ||
| $QueryBuilder.Add("Project='${Project}'$(($Description -or $Priority -or $Status -or $DueDate) ? "," : [string]::Empty)") |
There was a problem hiding this comment.
This could be problematic.
StefanGreve
commented
Dec 1, 2024
|
|
||
| #region User Completer | ||
|
|
||
| $UserCompleterCommands = @( |
There was a problem hiding this comment.
Regression: This doesn't seem to work anymore.
StefanGreve
commented
Dec 1, 2024
| $RegisterProjectParameter = { | ||
| param($Command, $Parameter, $WordToComplete, $CommandAst, $FakeBoundParameters) | ||
|
|
||
| $Projects = Get-TodoList | Select-Object -Property Project -Unique |
There was a problem hiding this comment.
Use -ExpandProperty here.
StefanGreve
commented
Dec 1, 2024
| } | ||
|
|
||
| # Script module or binary module file associated with this manifest. | ||
| RootModule = 'Todo.psm1' |
There was a problem hiding this comment.
- Fix file formatting.
StefanGreve
commented
Dec 1, 2024
| than ten tasks in your TODO list, return the entire TODO list instead. | ||
| #> | ||
| [Alias("gtask")] | ||
| [OutputType("Task")] |
There was a problem hiding this comment.
- Use proper type in all Cmdlets.
StefanGreve
commented
Dec 1, 2024
There was a problem hiding this comment.
- Add the other status badges for unit tests and deployments here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
ubuntu-latest?Import-Moduleerror withSQLite? Consider using https://github.com/mithrandyr/SimplySql instead