[ECP-9641-v9] Fix incorrect payment method filtering on virtual quote payments

[candemiralp]

Description

This PR refactors the payment method sorting and filtering functionality to fetch the correct payment methods on virtual quotes.

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the handling of Adyen payment methods within the Magento checkout process, specifically addressing issues with virtual quotes. The core change involves centralizing the fetching and caching of Adyen's /paymentMethods API response, which streamlines the filtering and sorting of available payment options. A new plugin has been introduced to ensure this refined logic is applied consistently when retrieving payment methods, leading to more accurate and efficient display of payment options for customers.

Highlights

• Payment Method API Response Caching: Introduced an in-memory caching mechanism for the Adyen /paymentMethods API response within the PaymentMethods helper, preventing redundant API calls and improving performance.
• Centralized Payment Method Filtering: Refactored payment method filtering logic to centralize the fetching of Adyen payment methods through the new getApiResponse method in the PaymentMethods helper, ensuring consistent behavior across different contexts.
• New Plugin for Payment Method Management: Added a new plugin, SortAndFilterAdyenPaymentMethods, to intercept Magento\Quote\Api\PaymentMethodManagementInterface::getList and apply Adyen-specific sorting and filtering to the available payment methods.
• Dependency Refactoring: Updated dependencies and method calls across MagentoPaymentDetails, PaymentMethodsFilter, and MultishippingPaymentMethods to align with the new centralized API response fetching and caching.
• Enhanced Test Coverage: Added new unit tests for the MultishippingPaymentMethods and SortAndFilterAdyenPaymentMethods plugins, and updated existing tests to reflect the refactored logic and dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the payment method filtering and sorting logic. Introducing an in-memory cache for the /paymentMethods API response in Helper/PaymentMethods.php is a great improvement to prevent redundant API calls. The new plugin SortAndFilterAdyenPaymentMethods centralizes the filtering logic by hooking into PaymentMethodManagementInterface::getList, which simplifies other parts of the code like MagentoPaymentDetails. The changes are well-structured and improve the overall design. I have one suggestion in Plugin/MultishippingPaymentMethods.php to make the code slightly more efficient and direct by using a value that is already available.

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud