[ECP-9670] Handling Intermediate Result Codes

[khushboo-singhvi]

Description
This PR aims to merge the feature of Handling Intermediate Result Codes
#3139

[gemini-code-assist]

Summary of Changes

Hello @khushboo-singhvi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience on the checkout success page by introducing explicit handling for intermediate payment result codes. It ensures that customers are promptly informed when their payment is still being processed, displaying a clear and localized message. This enhancement provides greater transparency and reduces potential confusion for payments that require additional time for confirmation, ultimately leading to a smoother post-purchase experience.

Highlights

• Intermediate Result Code Handling: Introduced new logic to identify and handle intermediate payment result codes (e.g., PENDING, RECEIVED) on the checkout success page, ensuring appropriate customer feedback.
• Customer-Facing Pending Message: Implemented a new message displayed to customers when their payment is still being processed, providing clear communication about the order status and expected next steps.
• Refactored Result Code Retrieval: Centralized the retrieval of the payment result code into a dedicated getResultCode() method within the Success block, improving code organization and error handling.
• Comprehensive Unit Testing: Added new unit tests for the getResultCode(), isIntermediateResult(), and getPendingMessage() methods to ensure the robustness and correctness of the new functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces new functionality to handle and display intermediate payment results on the checkout success page. Changes include adding methods in Block/Checkout/Success.php to retrieve payment result codes, determine if a result is intermediate (e.g., PENDING, RECEIVED), and generate a customer-facing pending message. Corresponding unit tests for these new methods have been added in Test/Unit/Block/Checkout/SuccessTest.php. The view/frontend/templates/checkout/success.phtml template is updated to conditionally display this pending message. A review comment highlights that new variable assignments in success.phtml were aligned using multiple spaces, which is inconsistent with other parts of the file and common coding standards, suggesting the use of a single space around assignment operators for better consistency and maintainability.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud