[ECP-9882] Allow using public_hash on recurring graphql payments

[candemiralp]

Description

This PR fixes the missing implementation for facilitating recurring GraphQL payments with public_hash of the vault payment token.

A recurring payment now can be completed via providing the vault payment method and corresponding public_hash in the additional data of the setPaymentMethodOnCart mutation.

Tested scenarios

• GraphQL headless recurring payments using public_hash value

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement by allowing the utilization of the public_hash for recurring payments processed via GraphQL. The changes involve modifying payment data assignment logic to correctly handle this hash, updating the GraphQL schema to expose the public_hash field, and configuring various vaulted Adyen payment methods within the GraphQL DI setup. This update aims to improve the flexibility and functionality of recurring payment processing through the API.

Highlights

• GraphQL Integration for Recurring Payments: This pull request enables the use of public_hash for recurring payments within the GraphQL API, allowing for more streamlined processing of vaulted payment methods.
• Payment Data Assignment: The payment data assignment observers (AdyenCcDataAssignObserver and AdyenPaymentMethodDataAssignObserver) have been updated to recognize and process the public_hash from payment tokens.
• GraphQL Schema Extension: The GraphQL schema has been extended to include the public_hash field in both AdyenAdditionalDataCc and AdyenAdditionalData input types, facilitating its use in GraphQL requests.
• Vaulted Payment Method Configuration: Dependency Injection configuration for GraphQL has been expanded to support a comprehensive list of vaulted Adyen payment methods, ensuring they can leverage the new public_hash functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for public_hash in Adyen payment methods, primarily for vaulted payments. The changes involve updating AdyenCcDataAssignObserver.php and AdyenPaymentMethodDataAssignObserver.php to handle public_hash in additional data, modifying etc/schema.graphqls to include public_hash in GraphQL input types and making stateData optional in AdyenAdditionalData, and extending etc/graphql/di.xml to register numerous adyen_*_vault payment methods. The reviewer noted that the public_hash functionality added to both observers lacks unit test coverage and requested new or updated test cases. Furthermore, the reviewer raised concerns about the maintainability of the large number of adyen_*_vault entries in di.xml, suggesting a more dynamic configuration approach to reduce duplication.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud