-
Notifications
You must be signed in to change notification settings - Fork 222
[ECP-9757] Magento Marketplace automation implementation #3205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @candemiralp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational elements for automating the Magento Marketplace release workflow. It sets up a new Node.js script designed to interact with both GitHub and Adobe's APIs, streamlining the initial steps of a release, such as gathering release details and authenticating with the marketplace platform. This automation aims to reduce manual effort and potential errors in the release process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new script for automating Magento Marketplace releases. While the intent is good, the script contains several critical issues that will prevent it from executing correctly. I've identified problems with function signatures, missing module imports, and calls to undefined functions. Additionally, there's a medium-severity issue related to how errors are handled, which could leak information into logs. My review provides specific code suggestions to address these critical bugs and improve the script's robustness.
|



Description
This workflow submits a new package to Adobe Marketplace EQP after publishing a new version on Github.