Skip to content

Conversation

@candemiralp
Copy link
Contributor

@candemiralp candemiralp commented Jan 2, 2026

Description

This workflow submits a new package to Adobe Marketplace EQP after publishing a new version on Github.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational elements for automating the Magento Marketplace release workflow. It sets up a new Node.js script designed to interact with both GitHub and Adobe's APIs, streamlining the initial steps of a release, such as gathering release details and authenticating with the marketplace platform. This automation aims to reduce manual effort and potential errors in the release process.

Highlights

  • New Automation Script: A new JavaScript file, .github/scripts/marketplace-release.js, has been added to automate parts of the Magento Marketplace release process.
  • GitHub Release Integration: The script includes functionality to fetch release information, such as release name, publish date, and release notes, directly from the GitHub API using a specified release tag.
  • Adobe EQP API Authentication: It also implements a method to obtain an access token from the Adobe EQP (Experience Platform) API, which is crucial for interacting with Adobe's services for marketplace submissions.
  • Environment Variable Configuration: All sensitive credentials and dynamic parameters, such as GitHub tokens, Adobe API IDs/secrets, and release tags, are configured to be loaded securely from environment variables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/marketplace-release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script for automating Magento Marketplace releases. While the intent is good, the script contains several critical issues that will prevent it from executing correctly. I've identified problems with function signatures, missing module imports, and calls to undefined functions. Additionally, there's a medium-severity issue related to how errors are handled, which could leak information into logs. My review provides specific code suggestions to address these critical bugs and improve the script's robustness.

@candemiralp candemiralp marked this pull request as ready for review January 7, 2026 14:43
@candemiralp candemiralp requested a review from a team as a code owner January 7, 2026 14:43
shubhamk67
shubhamk67 previously approved these changes Jan 9, 2026
@sonarqubecloud
Copy link

@candemiralp candemiralp merged commit c399da9 into main Jan 12, 2026
9 of 10 checks passed
@candemiralp candemiralp deleted the ECP-9757 branch January 12, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants