Skip to content

fix: secure workflows with pinned actions and npm ci #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 7 commits into from
Dec 19, 2025
Merged

fix: secure workflows with pinned actions and npm ci #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12ef965
Initial plan
Copilot Dec 18, 2025
de7a62c
fix: secure format.yml workflow by using PRs instead of direct pushes
Copilot Dec 18, 2025
b963546
fix: use yarn consistently in format.yml workflow
Copilot Dec 18, 2025
15f10c9
fix: prevent workflow loops and improve branch naming
Copilot Dec 18, 2025
f410092
docs: add comment explaining use of custom token in workflow
Copilot Dec 18, 2025
57f196f
fix: use npm ci with package-lock.json and keep direct push
Copilot Dec 19, 2025
9a21129
fix: use npm ci consistently across all workflows
Copilot Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
format:
if: ${{ github.event.commits != null && !startsWith(github.event.head_commit.message, 'style(fmt)') }}
if: ${{ github.event.commits != null && !startsWith(github.event.head_commit.message, 'style(fmt)') }}
permissions:
contents: write
runs-on: ubuntu-latest
Expand All @@ -19,7 +19,7 @@ jobs:
with:
node-version: 20.x
- run: |
npm install
npm ci --legacy-peer-deps
npm run lint:fix
- run: |
git config user.name AdyenAutomationBot
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/node-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Install dependencies
run: npm install
run: npm ci --legacy-peer-deps
- name: Lint code
run: npm run lint:fix && npm run lint

Expand All @@ -58,6 +58,6 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Install dependencies
run: npm install
run: npm ci --legacy-peer-deps
- name: Run tests with coverage
run: npm run test:coverage
3 changes: 1 addition & 2 deletions .github/workflows/npmpublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
node-version: '18.x'
- name: Install dependencies
run: yarn install --frozen-lockfile
run: npm ci --legacy-peer-deps
- name: Build package
run: npm run build
- name: Run tests
Expand Down Expand Up @@ -51,4 +51,3 @@ jobs:
run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_ADYEN_NODE_API_LIBRARY_TOKEN }}

2 changes: 1 addition & 1 deletion .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
cache: 'npm'

- name: Install dependencies
run: npm install
run: npm ci --legacy-peer-deps

- name: Run tests with coverage
run: npm run test:coverage
Expand Down
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ node_modules
coverage/
.env
lib/
build/
package-lock.json
build/
Loading