Skip to content

[configurationwebhooks] Code generation: update services and models#1736

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/configurationwebhooks
Open

[configurationwebhooks] Code generation: update services and models#1736
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/configurationwebhooks

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the configurationwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner July 23, 2026 13:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for top-up configuration webhooks by adding several new model definitions and updating the ConfigurationWebhooksHandler to handle TopUpConfigurationEventRequest and TopUpConfigurationUpdatedEventRequest payloads. The feedback highlights that some of the generated files, specifically models.ts and configurationWebhooksHandler.ts, are missing trailing newlines, and suggests updating the generator configuration to resolve this consistently.

export * from "./webhookTopUpConfigurationUpdated"
export * from "./webhookTopUpCounterparty"
export * from "./webhookTopUpMandate"
export * from "./webhookTopUpTrigger"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The generated file models.ts is missing a trailing newline at the end of the file. According to the repository's guidelines, all generated files in src/typings/ should consistently include a trailing newline. Please update the generator configuration to ensure a trailing newline is automatically appended to all generated files.

References
  1. Ensure generated model files (e.g., in src/typings/) consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.

*/
public getTopUpConfigurationUpdatedEventRequest(): configurationWebhooks.TopUpConfigurationUpdatedEventRequest {
return configurationWebhooks.ObjectSerializer.deserialize(this.payload, "TopUpConfigurationUpdatedEventRequest");
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The generated file configurationWebhooksHandler.ts is missing a trailing newline at the end of the file. According to the repository's guidelines, all generated files in src/typings/ should consistently include a trailing newline. Please update the generator configuration to ensure a trailing newline is automatically appended to all generated files.

References
  1. Ensure generated model files (e.g., in src/typings/) consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant