PayPal v6 (Task 3) — Split Funding Source Variants (Venmo, Credit, Pay Later) - #4127
PayPal v6 (Task 3) — Split Funding Source Variants (Venmo, Credit, Pay Later)#4127johnayeni wants to merge 44 commits into
Conversation
…bility) (#4087) * feature: add paypal service and sdk loader services * chore: pass csp nounce to script * chore: add empty changeset * chore: PR review comments * chore: update rollup config to add @paypal/paypal-js/sdk-v6 as an external dependency for es and cjs builds * fix: ts issues * chore: update yarn.lock * chore: add unit test for usePayPalV6 config * chore: adjust size limit * chore: PR review comments * chore: rename getElgibleMethods to getEligiblePaymentMethods * chore: fix circular dependency * chore: remove unneccessary paypal service check * chore: add paypal service undefined check
…horized callback is present
🦋 Changeset detectedLatest commit: 44104fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces split PayPal components (PayPalPayLater, PaypalCredit, and Venmo) by extracting shared logic into a new BasePaypalElement class, adding Storybook stories, and updating component mappings. Key feedback includes adding missing dependencies (countryCode and amount) to the useEffect hook in PayPalMessaging.tsx, destructuring and passing countryCode in PayPalPaylaterComponent.tsx, implementing formatProps in BasePaypalElement to support zero-auth flows, and correcting the Venmo configuration key to paypal_venmo in Dropin.stories.tsx.
size-limit report 📦
|
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Strict TypeScript Scan ResultsTotal: 2979 errors (baseline: 2984) | ✅ Pass Files with regressions (0 files)
Last updated: 2026-08-07 13:17:50 UTC |
|
1 participant
📋 Pull Request Checklist
📝 Summary
🧪 Tested scenarios
🔗 Related GitHub Issue / Internal Ticket number
Closes: