Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intermediate commit #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Dev-Bray
Copy link
Collaborator

@Dev-Bray Dev-Bray commented Jul 5, 2022

No description provided.

@AfricanBongo
Copy link
Owner

This looks quite fine.
However, we are aiming to make our classes immutable, i.e. member fields can be set or changed once an object has been created.
So make sure that all data classes (classes that only hold data and don't make any computations) have member variables that are immutable, are only set in stone upon creating of a new object, and that there no setter methods.
And as for the classes associated with the Google Places API set them elsewhere in a different branch that isn't the main branch and also reference from the Google Places Android SDK which would make it easier as they already provide classes and stop us from using JSONs altogether.
And then when you submit next time convert the Java code into Kotlin so that the configurations remain the same.

Thank you @Dev-Bray

@AfricanBongo AfricanBongo requested review from AfricanBongo and removed request for AfricanBongo July 5, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants