Use a single atomicRearrange for liquidityPool repay #11059
+46
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
cth-atomicRepay
branch
from
79403f6 to
abe4a95
Compare
Deploying agoric-sdk with
|
| Latest commit: |
6973a09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b581cbf3.agoric-sdk.pages.dev |
| Branch Preview URL: | https://cth-atomicrepay.agoric-sdk.pages.dev |
dckc
reviewed
Feb 27, 2025
| [fromSeat, feeSeat, { ContractFee }, { USDC: ContractFee }], | ||
| ]), | ||
| ); | ||
| zcf.atomicRearrange([ |
There was a problem hiding this comment.
I could swear zcf throws when this harden(...) is missing. But maybe only the individual parts need to be hardened?
There was a problem hiding this comment.
done.
Do you believe that even though tests all passed?
There was a problem hiding this comment.
I think fast-usdc.contract.test.ts is sufficiently high fidelity that if the tests pass, the code would work on chain without harden(...).
Comment on lines
-566
to
+533
| const actual = repayCalc( | ||
| shareWorth, | ||
| fromSeatAllocation, | ||
| amounts, | ||
| encumberedBalance, | ||
| poolStats, | ||
| ); | ||
| const actual = repayCalc(shareWorth, amounts, encumberedBalance, poolStats); |
There was a problem hiding this comment.
getting these all on one line makes me happy 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repaying the liquidity pool was being done with two sequential calls to
zcf.atomicRearrange(). This refactors so that each of the calls onrepay()includes a TransferPart to indicate the source of the funds. There was no need to rearrange the funds into matching keywords with a separate rearrange.Security Considerations
None.
Scaling Considerations
None
Documentation Considerations
Could we have done a better job of explaining
atomicRearrange()?Testing Considerations
Cleaned up existing tests.
settler.test.jsdoes extensive tracing, and records and verifies many calls, so this had to be updated, since a call toatomicRearrangewas dropped, and the signature ofrepay()changed.Upgrade Considerations
There is no urgency to getting this change onto master. The behavior should be interchangeable for all successful transactions.