Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: multichain for Fast USDC noble ICA update #11060

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dckc
Copy link
Member

@dckc dckc commented Feb 26, 2025

closes: #11013

Description / Considerations

a3p and multichain test for Noble ICA upgrade

Security / Scaling / Documentation Considerations

none

Testing / Upgrade Considerations

complements testing work from #11025

@dckc dckc changed the title Dc noble conn mc test: multichain for Fast USDC noble ICA update Feb 26, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: e463361
Status: ✅  Deploy successful!
Preview URL: https://f3e42d0c.agoric-sdk.pages.dev
Branch Preview URL: https://dc-noble-conn-mc.agoric-sdk.pages.dev

View logs

@dckc dckc force-pushed the dc-noble-conn branch 3 times, most recently from 7e08951 to 2ea79b6 Compare February 26, 2025 21:54
@dckc dckc force-pushed the dc-noble-conn branch 2 times, most recently from ebf1bd7 to 07f3dae Compare February 27, 2025 20:33
mergify bot added a commit that referenced this pull request Feb 27, 2025
refs: #11013

## Description

- feat(fast-usdc): `ChainHub` update interfaces
- fix(fast-usdc): prepare to repair Noble Account
- feat(fast-usdc): core eval to update chainInfo, noble ICA
  - feat(builders): to reconfigure Fast USDC
- test(boot): start fastUsdc using fast-usdc-beta-1 release
  - chore(boot): cache fast-usdc-beta-1 release artifacts
- test(boot): upgrade Fast USDC; update noble ICA
- test(boot): oracles accept before upgrade

### Security Considerations

~~`creatorFacet.getChainHub()` increases the surface area of the contract.~~

### Scaling Considerations

none, I think.

### Testing Considerations

 - unit tests for chainHub methods
 - bootstrap test for upgrade

for a later PR:
  - a3p, multichain-testing: #11060

### Upgrade / Documentation Considerations

OCW operators have to accept their invitations before the upgrade, since their invitations are attached to ephemeral offer handlers. Consideration of addressing that is postponed to...

 - #11057
Base automatically changed from dc-noble-conn to master February 27, 2025 21:21
@dckc dckc marked this pull request as ready for review February 27, 2025 22:41
@dckc dckc requested a review from a team as a code owner February 27, 2025 22:41
});
});

test.failing(`incarnation number`, async t => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as of yet we don't really know this submission is executing. I think we have enough coverage to move forward but we need to come back to this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing due to a regression in getIncarnation(...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm moving the a3p test out of this PR... probably combining it with #11055 and #11054

@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Feb 27, 2025
@0xpatrickdev 0xpatrickdev added the force:integration Force integration tests to run on PR label Feb 27, 2025
Copy link
Contributor

mergify bot commented Feb 28, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 28, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11060 has been dequeued due to: review decision is inaccessible

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@dckc dckc removed the automerge:rebase Automatically rebase updates, then merge label Feb 28, 2025
Copy link
Contributor

mergify bot commented Feb 28, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #11060 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • label=automerge:rebase

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request for a Noble ICA for Fast USDC has yet to settle - misconfigured host
3 participants