-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: multichain for Fast USDC noble ICA update #11060
base: master
Are you sure you want to change the base?
Conversation
Deploying agoric-sdk with
|
Latest commit: |
e463361
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f3e42d0c.agoric-sdk.pages.dev |
Branch Preview URL: | https://dc-noble-conn-mc.agoric-sdk.pages.dev |
7e08951
to
2ea79b6
Compare
6101c0d
to
35293a0
Compare
35293a0
to
0328ba4
Compare
ebf1bd7
to
07f3dae
Compare
refs: #11013 ## Description - feat(fast-usdc): `ChainHub` update interfaces - fix(fast-usdc): prepare to repair Noble Account - feat(fast-usdc): core eval to update chainInfo, noble ICA - feat(builders): to reconfigure Fast USDC - test(boot): start fastUsdc using fast-usdc-beta-1 release - chore(boot): cache fast-usdc-beta-1 release artifacts - test(boot): upgrade Fast USDC; update noble ICA - test(boot): oracles accept before upgrade ### Security Considerations ~~`creatorFacet.getChainHub()` increases the surface area of the contract.~~ ### Scaling Considerations none, I think. ### Testing Considerations - unit tests for chainHub methods - bootstrap test for upgrade for a later PR: - a3p, multichain-testing: #11060 ### Upgrade / Documentation Considerations OCW operators have to accept their invitations before the upgrade, since their invitations are attached to ephemeral offer handlers. Consideration of addressing that is postponed to... - #11057
0328ba4
to
6caf368
Compare
}); | ||
}); | ||
|
||
test.failing(`incarnation number`, async t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as of yet we don't really know this submission is executing. I think we have enough coverage to move forward but we need to come back to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's failing due to a regression in getIncarnation(...)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
f853552
to
6a80bfa
Compare
6a80bfa
to
e463361
Compare
This pull request has been removed from the queue for the following reason: Pull request #11060 has been dequeued due to: review decision is inaccessible You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
This pull request has been removed from the queue for the following reason: Pull request #11060 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
closes: #11013
Description / Considerations
a3p and multichain test for Noble ICA upgrade
Security / Scaling / Documentation Considerations
none
Testing / Upgrade Considerations
complements testing work from #11025