Skip to content

Fix null reference error for invalid times #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herrkoch wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix null reference error for invalid times #371

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
554c051
Fix null reference error for invalid times
herrkoch Oct 16, 2020
53d0e91
Using isValid instead of invalid
herrkoch Oct 16, 2020
8692f5c
Merge branch 'master' into fix-#349
Agranom Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/material-timepicker/services/time-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export class TimeAdapter {
}
const {format} = opts;
const parsedTime = TimeAdapter.parseTime(time, opts).setLocale(TimeAdapter.DEFAULT_LOCALE);

if (!parsedTime.isValid) {
return null;
Copy link
Author

@herrkoch herrkoch Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to point out that I prefer null here over 'Invalid Time', otherwise the invalid value entered by the user will be replaced with 'Invalid Time' in the input field, which is not nice as the user won't be able to correct his/her mistake. I'd leave it to the developer to put form validation on the input field.

}
if (format !== 24) {
return parsedTime.toLocaleString({
...DateTime.TIME_SIMPLE,
Expand Down