Skip to content

Conversation

@l-qing
Copy link

@l-qing l-qing commented Dec 29, 2025

  • Add version information ldflags for component-base
  • Add version information ldflags for client-go
  • Ensure version info is embedded in kubectl binary

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@kiloconnect
Copy link

kiloconnect bot commented Dec 29, 2025

✅ No Issues Found - Re-reviewed

1 files reviewed | Confidence: 95% | Recommendation: Merge

Review Details

Files: .goreleaser-alauda.yml

Checked: Security, bugs, performance, error handling, version embedding patterns

Analysis: The PR successfully adds version ldflags for kubectl builds that follow established Kubernetes ecosystem patterns. The changes embed version information from both k8s.io/component-base/version and k8s.io/client-go/pkg/version packages, which are the standard packages used across Kubernetes-related projects for version information. The ldflags format is correct and the implementation aligns with Go build best practices.

Re-review Confirmation: Confirmed that the ldflags match exactly with those defined in hack/lib/version.sh (lines 158-161), both version packages exist and are widely used throughout the codebase, and kubectl already imports and uses the component-base version package. No issues found.

- Add version information ldflags for component-base
- Add version information ldflags for client-go
- Ensure version info is embedded in kubectl binary
@l-qing l-qing force-pushed the feat/kubectl-version-ldflags branch from c6060bc to 664a7d8 Compare December 29, 2025 10:44
@l-qing l-qing merged commit 2bcf1a0 into alauda-v1.33.7 Dec 29, 2025
1 check passed
@l-qing l-qing deleted the feat/kubectl-version-ldflags branch December 29, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants