chore: enhance upgrade command to support custom environment variable… #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and improve test command execution
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the upgrade command functionality by adding support for custom environment variables in command execution and improving the test command execution logic to handle workspace paths more efficiently.
- Adds environment variable support to the Command struct and execution logic
- Improves workspace path handling in the upgrade command for test execution
- Refactors test subpath logic to be more flexible and maintainable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/exec/exec.go | Adds Env field to Command struct and implements environment variable inheritance with custom variable support |
| cmd/upgrade_command.go | Refactors workspace path construction logic for test command execution to handle optional test subpaths |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+200
to
+202
| workspace := uc.config.OperatorConfig.Workspace | ||
| if version.TestSubPath != "" { | ||
| workspace = fmt.Sprintf("%s/%s", uc.config.OperatorConfig.Workspace, version.TestSubPath) |
There was a problem hiding this comment.
The workspace path construction duplicates uc.config.OperatorConfig.Workspace. Consider using filepath.Join() for cross-platform path handling and store the base workspace in a variable to avoid repetition.
Suggested change
| workspace := uc.config.OperatorConfig.Workspace | |
| if version.TestSubPath != "" { | |
| workspace = fmt.Sprintf("%s/%s", uc.config.OperatorConfig.Workspace, version.TestSubPath) | |
| baseWorkspace := uc.config.OperatorConfig.Workspace | |
| workspace := baseWorkspace | |
| if version.TestSubPath != "" { | |
| workspace = filepath.Join(baseWorkspace, version.TestSubPath) |
yhuan123
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and improve test command execution