Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #2

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Test #2

wants to merge 12 commits into from

Conversation

AlbumenJ
Copy link
Owner

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Owner Author

Test comment

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #2 (a7ea8c4) into master (70b6fb3) will increase coverage by 0.87%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
+ Coverage     59.36%   60.24%   +0.87%     
  Complexity      508      508              
============================================
  Files          1028     1028              
  Lines         41525    41531       +6     
  Branches       6038     6038              
============================================
+ Hits          24652    25021     +369     
+ Misses        14128    13760     -368     
- Partials       2745     2750       +5     
Impacted Files Coverage Δ Complexity Δ
...o/rpc/cluster/support/wrapper/AbstractCluster.java 62.16% <ø> (ø) 0.00 <0.00> (ø)
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/apache/dubbo/common/BaseServiceMetadata.java 97.87% <100.00%> (+48.93%) 0.00 <0.00> (ø)
...ain/java/org/apache/dubbo/common/URLStrParser.java 87.42% <100.00%> (+9.58%) 0.00 <0.00> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 96.15% <100.00%> (+33.11%) 0.00 <0.00> (ø)
...n/java/org/apache/dubbo/common/utils/LFUCache.java 79.61% <100.00%> (ø) 0.00 <0.00> (ø)
...ng/telnet/support/command/StatusTelnetHandler.java 84.09% <100.00%> (+84.09%) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 88.03% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b6fb3...a7ea8c4. Read the comment docs.

@AlbumenJ
Copy link
Owner Author

test comment

@AlbumenJ
Copy link
Owner Author

test comment

Copy link
Owner Author

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@AlbumenJ
Copy link
Owner Author

Test comment

@AlbumenJ
Copy link
Owner Author

Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants