Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deserialize big block on rayon thread #3316

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

elderhammer
Copy link
Contributor

This PR is to partially resolve #3315.

@vicsn vicsn requested a review from ljedrz June 18, 2024 19:42
@vicsn
Copy link
Contributor

vicsn commented Jun 18, 2024

Can't add @joske as reviewer, so tagging manually.

ljedrz
ljedrz previously approved these changes Jun 19, 2024
@elderhammer
Copy link
Contributor Author

How to handle failed checks?

@vicsn
Copy link
Contributor

vicsn commented Jun 21, 2024

How to handle failed checks?

You can leave it for now, someone from Aleo Foundation will have to manually trigger CI, this is a spam prevention measure.

node/bft/src/gateway.rs Outdated Show resolved Hide resolved
ljedrz
ljedrz previously approved these changes Jun 26, 2024
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit (and related adjustments it will require) and a rebase.

node/bft/src/gateway.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Malicious validator can send fake BlockResponse to block honest validators from processing messages
4 participants