cava nonsafe threads #4587
Open
cava nonsafe threads #4587
+144
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukashonakV
force-pushed
the
cavaIssue#4567
branch
from
0c8359f to
d72f38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @Alexays ,
This PR is based on investigation of the #4567 .
Thanks to @DaDiamondArmor and @mutoroglin I realized backend and frontend was not implemented as well.
During investigation I found non safe threading that's why it is segfaults from time to time, freezes and race conditions.
Now backend was deeply reworked. Dev tests shown that module is very stabled now. In additional it was fixed an issue when audio server for some reason is restarted. No need more to restart in that case waybar. cava will get this.
But the most surprising for me was - the significant performance benefit. Even with the single monitor CPU consumption decreased 10x times. I wasn't expected such big improvement.
In the same time it was again updated libcava because of -> karlstav/cava#698 . I also provided big rework to the upstream in order to avoid of memory leaking. So for now waybar + cava - the only one small memory leak still exists because of issue somewhere deep in the pipewire driver.
Finally this PR closes #4567
Thank you