Alien dictionary (additional task) #21

Stargazer2005 · 2024-11-15T13:33:52Z

No description provided.

…itional_task)

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-15T13:35:55Z

additional_tasks/alien_dictionary/src/test.cpp

+
+// Helper function to capture the output of FindAlphabeticOrder
+std::string CaptureOutput(const std::vector<std::string>& dictionary) {
+  std::ostringstream output;


warning: variable 'output' of type 'std::ostringstream' (aka 'basic_ostringstream') can be declared 'const' [misc-const-correctness]

Suggested change

std::ostringstream output;

std::ostringstream const output;

github-actions · 2024-11-15T13:35:55Z

additional_tasks/alien_dictionary/src/utils.hpp

+
+#include <stack>
+
+#include "graph.hpp"


warning: 'graph.hpp' file not found [clang-diagnostic-error]

#include "graph.hpp" ^

github-actions · 2024-11-15T13:35:55Z

lib/src/graph.hpp

+      for (const auto &neighbor : vertex->adjacent) {
+        std::cout << neighbor->data << " ";
+      }
+      std::cout << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << std::endl;

std::cout << '\n';

github-actions · 2024-11-15T13:35:55Z

lib/src/graph.hpp

+  }
+
+ protected:
+  std::vector<std::shared_ptr<Vertex<T>>> vertices_;


warning: member variable 'vertices_' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]

std::vector<std::shared_ptr<Vertex<T>>> vertices_; ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-18T00:14:44Z

additional_tasks/alien_dictionary/src/test.cpp

+
+// Helper function to capture the output of FindAlphabeticOrder
+std::string CaptureOutput(const std::vector<std::string>& dictionary) {
+  std::ostringstream output;


warning: variable 'output' of type 'std::ostringstream' (aka 'basic_ostringstream') can be declared 'const' [misc-const-correctness]

Suggested change

std::ostringstream output;

std::ostringstream const output;

github-actions · 2024-11-18T00:14:44Z

lib/src/graph.hpp

+      for (const auto &neighbor : vertex->adjacent) {
+        std::cout << neighbor->data << " ";
+      }
+      std::cout << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << std::endl;

std::cout << '\n';

github-actions · 2024-11-18T00:14:44Z

lib/src/graph.hpp

+  }
+
+ protected:
+  std::vector<std::shared_ptr<Vertex<T>>> vertices_;


warning: member variable 'vertices_' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]

std::vector<std::shared_ptr<Vertex<T>>> vertices_; ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 23. Check the log or trigger a new build to see more.

github-actions · 2024-11-18T13:25:23Z

additional_tasks/alien_dictionary/src/test.cpp

+
+// Helper function to capture the output of FindAlphabeticOrder
+std::string CaptureOutput(const std::vector<std::string>& dictionary) {
+  std::ostringstream output;


warning: variable 'output' of type 'std::ostringstream' (aka 'basic_ostringstream') can be declared 'const' [misc-const-correctness]

Suggested change

std::ostringstream output;

std::ostringstream const output;

github-actions · 2024-11-18T13:25:24Z

lib/src/graph.hpp

+};
+
+template<typename T, typename VT>
+concept IsVertex = std::derived_from<T, Vertex<VT>>;


warning: 'T' does not refer to a value [clang-diagnostic-error]

concept IsVertex = std::derived_from<T, Vertex<VT>>; ^

Additional context

lib/src/graph.hpp:19: declared here

template<typename T, typename VT> ^

github-actions · 2024-11-18T13:25:24Z

lib/src/graph.hpp

+};
+
+template<typename T, typename VT>
+concept IsVertex = std::derived_from<T, Vertex<VT>>;


warning: a template declaration can only declare a single entity [clang-diagnostic-error]

concept IsVertex = std::derived_from<T, Vertex<VT>>; ^

github-actions · 2024-11-18T13:25:24Z

lib/src/graph.hpp

+};
+
+template<typename T, typename VT>
+concept IsVertex = std::derived_from<T, Vertex<VT>>;


warning: no member named 'derived_from' in namespace 'std' [clang-diagnostic-error]

concept IsVertex = std::derived_from<T, Vertex<VT>>; ^

github-actions · 2024-11-18T13:25:24Z

lib/src/graph.hpp

+};
+
+template<typename T, typename VT>
+concept IsVertex = std::derived_from<T, Vertex<VT>>;


warning: unknown type name 'concept' [clang-diagnostic-error]

concept IsVertex = std::derived_from<T, Vertex<VT>>; ^

github-actions · 2024-11-18T13:25:25Z

lib/src/graph.hpp

+   * Add a new vertex to the graph
+   * @param data
+   */
+  virtual void AddVertex(const T &data) {


warning: unknown type name 'T' [clang-diagnostic-error]

virtual void AddVertex(const T &data) { ^

github-actions · 2024-11-18T13:25:25Z

lib/src/graph.hpp

+    vertices_.push_back(std::make_shared<VertexType>(data));
+  };
+
+  std::shared_ptr<VertexType> operator[](size_t index) {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

std::shared_ptr<VertexType> operator[](size_t index) { ^

github-actions · 2024-11-18T13:25:25Z

lib/src/graph.hpp

+    return vertices_[index];
+  }
+
+  const std::shared_ptr<VertexType> operator[](size_t index) const {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

const std::shared_ptr<VertexType> operator[](size_t index) const { ^

github-actions · 2024-11-18T13:25:25Z

lib/src/graph.hpp

+   * @param vertex
+   * @return size_t
+   */
+  size_t Find(const T &vertex) const {


warning: unknown type name 'T' [clang-diagnostic-error]

size_t Find(const T &vertex) const { ^

github-actions · 2024-11-18T13:25:25Z

lib/src/graph.hpp

+   * Remove a vertex from the graph
+   * @param vertex
+   */
+  virtual void RemoveVertex(std::shared_ptr<VertexType> vertex) {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

virtual void RemoveVertex(std::shared_ptr<VertexType> vertex) { ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-18T13:27:49Z

additional_tasks/alien_dictionary/src/test.cpp

+
+// Helper function to capture the output of FindAlphabeticOrder
+std::string CaptureOutput(const std::vector<std::string>& dictionary) {
+  std::ostringstream output;


warning: variable 'output' of type 'std::ostringstream' (aka 'basic_ostringstream') can be declared 'const' [misc-const-correctness]

Suggested change

std::ostringstream output;

std::ostringstream const output;

github-actions · 2024-11-18T13:27:49Z

lib/src/graph.hpp

+};
+
+template <typename T, typename VT>
+concept IsVertex = std::derived_from<T, Vertex<VT>>;


warning: 'T' does not refer to a value [clang-diagnostic-error]

concept IsVertex = std::derived_from<T, Vertex<VT>>; ^

Additional context

lib/src/graph.hpp:19: declared here

template <typename T, typename VT> ^

github-actions · 2024-11-18T13:27:49Z

lib/src/graph.hpp

+/// @tparam VertexType
+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>


warning: expected ';' at end of declaration [clang-diagnostic-error]

Suggested change

requires IsVertex<VertexType, T>

requires IsVertex<VertexType, T>;

github-actions · 2024-11-18T13:27:49Z

lib/src/graph.hpp

+/// @tparam VertexType
+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>


warning: unknown type name 'requires' [clang-diagnostic-error]

requires IsVertex<VertexType, T> ^

github-actions · 2024-11-18T13:27:50Z

lib/src/graph.hpp

+/// @tparam VertexType
+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>


warning: variable template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list [clang-diagnostic-error]

Suggested change

requires IsVertex<VertexType, T>

requires IsVertex

github-actions · 2024-11-18T13:27:50Z

lib/src/graph.hpp

+   * @param target
+   */
+  virtual void RemoveDirEdge(std::shared_ptr<VertexType> source,
+                             std::shared_ptr<VertexType> target) {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

std::shared_ptr<VertexType> target) { ^

github-actions · 2024-11-18T13:27:50Z

lib/src/graph.hpp

+   * @param vertex_1
+   * @param vertex_2
+   */
+  virtual void AddEdge(std::shared_ptr<VertexType> vertex_1,


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

virtual void AddEdge(std::shared_ptr<VertexType> vertex_1, ^

github-actions · 2024-11-18T13:27:50Z

lib/src/graph.hpp

+   * @param vertex_2
+   */
+  virtual void AddEdge(std::shared_ptr<VertexType> vertex_1,
+                       std::shared_ptr<VertexType> vertex_2) {


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

std::shared_ptr<VertexType> vertex_2) { ^

github-actions · 2024-11-18T13:27:50Z

lib/src/graph.hpp

+   * @param vertex_1
+   * @param vertex_2
+   */
+  virtual void RemoveEdge(std::shared_ptr<VertexType> vertex_1,


warning: use of undeclared identifier 'VertexType' [clang-diagnostic-error]

virtual void RemoveEdge(std::shared_ptr<VertexType> vertex_1, ^

github-actions · 2024-11-18T13:27:51Z

lib/src/graph.hpp

+  }
+
+ protected:
+  std::vector<std::shared_ptr<VertexType>> vertices_;


warning: member variable 'vertices_' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]

std::vector<std::shared_ptr<VertexType>> vertices_; ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-18T18:02:01Z

additional_tasks/alien_dictionary/src/test.cpp

+
+// Helper function to capture the output of FindAlphabeticOrder
+std::string CaptureOutput(const std::vector<std::string>& dictionary) {
+  std::ostringstream output;


warning: variable 'output' of type 'std::ostringstream' (aka 'basic_ostringstream') can be declared 'const' [misc-const-correctness]

Suggested change

std::ostringstream output;

std::ostringstream const output;

github-actions · 2024-11-18T18:02:02Z

lib/src/graph.hpp

+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>
+class Graph {


warning: constructor does not initialize these fields: vertices_ [cppcoreguidelines-pro-type-member-init]

lib/src/graph.hpp:209:

- std::vector<std::shared_ptr<VertexType>> vertices_; + std::vector<std::shared_ptr<VertexType>> vertices_{};

github-actions · 2024-11-18T18:02:02Z

lib/src/graph.hpp

+/// @tparam T
+template <typename VertexType, typename T>
+  requires IsVertex<VertexType, T>
+class Graph {


warning: destructor of 'Graph' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]

class Graph { ^

Additional context

lib/src/graph.hpp:27: make it public and virtual

class Graph { ^

github-actions · 2024-11-18T18:02:02Z

lib/src/graph.hpp

+  }
+
+ protected:
+  std::vector<std::shared_ptr<VertexType>> vertices_;


warning: member variable 'vertices_' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]

std::vector<std::shared_ptr<VertexType>> vertices_; ^

Stargazer2005 added 17 commits September 21, 2024 19:56

Add graph class in utils

f0bd3c8

Undirected edge adding func

1d846ff

Rename files

d3602f6

Graph class improvement

22ffad7

Return utils files

3709d12

Move methods definitions to the header

e3e497c

Improve naming

75d57fa

Improve methods naming

fa8ba68

Add Size() method

f13ca9f

Disacard changes

2964511

Add indices methods

5ae7967

codestyle improvement

bbf95ff

added weighted graph class

9c125dd

Merge branch 'AlgorithmsDafeMipt2024:main' into alien_dictionary-(add…

f336d1a

…itional_task)

fix graph methods

c8bafd0

add problem describtion

7e7f127

task solution

c39126d

github-actions bot reviewed Nov 15, 2024

View reviewed changes

add note in README

fa06373

github-actions bot reviewed Nov 18, 2024

View reviewed changes

make concept usage in lib

b839a46

github-actions bot reviewed Nov 18, 2024

View reviewed changes

format changes

89c7dbe

github-actions bot reviewed Nov 18, 2024

View reviewed changes

rewrite task due to lib changes

22d5ff8

github-actions bot reviewed Nov 18, 2024

View reviewed changes

	requires IsVertex<VertexType, T>
	requires IsVertex<VertexType, T>;

Alien dictionary (additional task) #21

Are you sure you want to change the base?

Alien dictionary (additional task) #21

Conversation

Stargazer2005 commented Nov 15, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment