homework_1 #7
Open
homework_1 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostPointer
requested changes
Mar 2, 2024
task_01/src/topology_sort.cpp
Outdated
| @@ -1 +1,65 @@ | |||
| #include "topology_sort.hpp" | |||
|
|
|||
| // O(logn) | |||
| int BinSearch(std::vector<int> mas, int num) { | |||
There was a problem hiding this comment.
mas, n, l, r - плохие названия переменных
task_01/src/topology_sort.cpp
Outdated
| int n = mas.size(); | ||
| int l = 0; | ||
| int r = n - 1; | ||
| int ind = n / 2; |
There was a problem hiding this comment.
ind это index? если да, то давай не будем экономить символы
LostPointer
reviewed
Mar 23, 2024
task_01/src/topology_sort.cpp
Outdated
| right--; | ||
| } | ||
| } | ||
| return {-1, -1}; |
There was a problem hiding this comment.
как отличить результат (-1, -1) от отсутствия результата?
There was a problem hiding this comment.
такого результата не может быть ни в каком случае, оба числа это индексы от 0 до len-1
LostPointer
approved these changes
Mar 23, 2024
task_01/src/topology_sort.cpp
Outdated
| right--; | ||
| } | ||
| } | ||
| return {-1, -1}; |
LostPointer
requested changes
Jun 16, 2024
task_01/src/topology_sort.hpp
Outdated
There was a problem hiding this comment.
давай файлы переименуем с тем что в них содержится
task_02/src/stack.cpp
Outdated
There was a problem hiding this comment.
это же 1ое задание? тогда верни как было, что бы тесты проходили
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.