-
-
Notifications
You must be signed in to change notification settings - Fork 8k
fix: enhance file deletion handling and add option to hide uploading files and fix cloudreve refresh_token get error #9200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alist666
wants to merge
1
commit into
main
Choose a base branch
from
cloudreve_v4_token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -175,8 +175,8 @@ func (d *CloudreveV4) doLogin(needCaptcha bool) error { | |
| } | ||
|
|
||
| func (d *CloudreveV4) refreshToken() error { | ||
| var token Token | ||
| if token.RefreshToken == "" { | ||
| //var token Token | ||
| if d.RefreshToken == "" { | ||
| if d.Username != "" { | ||
| err := d.login() | ||
| if err != nil { | ||
|
|
@@ -185,6 +185,7 @@ func (d *CloudreveV4) refreshToken() error { | |
| } | ||
| return nil | ||
| } | ||
| var token Token | ||
| err := d.request(http.MethodPost, "/session/token/refresh", func(req *resty.Request) { | ||
| req.SetBody(base.Json{ | ||
| "refresh_token": d.RefreshToken, | ||
|
|
@@ -470,7 +471,7 @@ func (d *CloudreveV4) upS3(ctx context.Context, file model.FileStreamer, u FileU | |
| } | ||
|
|
||
| // 上传成功发送回调请求 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing the HTTP method from POST to GET for the callback request might have implications on the server-side logic. Ensure that the server is configured to handle GET requests for this endpoint. |
||
| return d.request(http.MethodPost, "/callback/s3/"+u.SessionID+"/"+u.CallbackSecret, func(req *resty.Request) { | ||
| return d.request(http.MethodGet, "/callback/s3/"+u.SessionID+"/"+u.CallbackSecret, func(req *resty.Request) { | ||
| req.SetBody("{}") | ||
| }, nil) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retry mechanism for lock conflicts in file deletion is a good addition. However, ensure that the error handling for the
del()function is robust enough to handle unexpected errors beyond lock conflicts.