delete[] when failed to unbox

Aliucord · Aug 28, 2024 · 7baa88c · 7baa88c
1 parent 67834a9
commit 7baa88c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/src/main/cpp/invoke_constructor.cpp b/core/src/main/cpp/invoke_constructor.cpp
@@ -135,10 +135,12 @@ bool InvokeConstructorWithArgs(JNIEnv *env, jobject instance, jobject constructo
     if (env->ExceptionOccurred()) return false;
 
     auto* unboxedArgs = new jvalue[argsCount];
-    if (!unboxArgs(env, constructor, args, argsCount, unboxedArgs)) return false;
+    if (!unboxArgs(env, constructor, args, argsCount, unboxedArgs)) {
+        delete[] unboxedArgs;
+        return false;
+    }
 
     env->CallVoidMethodA(instance, constructorMethodId, unboxedArgs);
-
     delete[] unboxedArgs;
     return !env->ExceptionOccurred();
 }