Merged
Conversation
Contributor
Author
|
solidqueue is still logging heartbeat updates every minute so I'll continue working on a fix for that, but wanted to push this as a draft first |
jlvallelonga
commented
Oct 15, 2024
Contributor
Author
There was a problem hiding this comment.
I'll try to get a PR in for solidqueue to make this an official option
Contributor
Author
There was a problem hiding this comment.
keithschacht
approved these changes
Oct 17, 2024
Contributor
keithschacht
left a comment
keithschacht
left a comment
There was a problem hiding this comment.
👍 looks good, if you’re done with this one feel free to merge in. I couldn’t tell if there was something else you wanted to add to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workers weren't logging correctly so this fixes them