Replace imports of distutils. #385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in [Debian bug #1083070], the Python module distutils is going to be removed entirely from the upcoming Debian release, following the deprecation on Python side of the distutils module. Removal of distutils is causing test failures in bmtk though: Traceback: /usr/lib/python3.12/importlib/__init__.py:90: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/simulator/filternet/test_filternet_movies.py:5: in <module> from bmtk.utils.sim_setup import build_env_filternet /usr/lib/python3/dist-packages/bmtk/utils/sim_setup.py:32: in <module> from distutils.dir_util import copy_tree E ModuleNotFoundError: No module named 'distutils' These changes replace copy_tree invocations by shutil.copytree, with the option to clobber existing directories by default, as otherwise the refusal of erasing the target directory will cause other test regressions. The version sort invocation perusing LooseVersion is replaced by invocations of the bare packaging.version.Version. [Debian bug #1083070]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083070 Signed-off-by: Étienne Mollier <[email protected]>
emollier
force-pushed
the
rm-distutils
branch
from
91617e0 to
39c1bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in Debian bug #1083070, the Python module distutils is going to be removed entirely from the upcoming Debian release, following the deprecation on Python side of the distutils module. Removal of distutils is causing test failures in bmtk though:
These changes replace copy_tree invocations by shutil.copytree, with the option to clobber existing directories by default, as otherwise the refusal of erasing the target directory will cause other test regressions. The version sort invocation perusing LooseVersion is replaced by invocations of the bare packaging.version.Version.