This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
add safety checker #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prototype of a safety checker, which should help to prevent shooting yourself in the foot. If you are sure of what you are doing you can opt out of the checker by using the `--bypass-all-checks` flag, but it is more recommended using the new `unsafe` token, which will skip individual functions. It can be used like this: `copy(@name, @name.txt) unsafe print(@sum=sha256)`. I am not sure if maintaining both options is too much overkill, though.
I disabled it because i was testing the safety checker
…ead of exiting directly It used to exit directly, which was not library-friendly. parse error instead returned an `Err`, and now safety errors also do so.
|
@Cybergsus and I agreed in the Discord that it was redundant and unnecessary maintaining both options. |
|
Then we can close #5 after this |
yep, this pr is linked to it, so after merging this the issue will be automatically closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype of a safety checker, which should help to prevent shooting yourself in the foot. If you are sure of what you are doing you can opt out of the checker by using the
--bypass-all-checksflag, but it is more recommended using the newunsafetoken, which will skip individual functions. It can be used like this:copy(@name, @name.txt) unsafe print(@sum=sha256). I am not sure if maintaining both options is too much overkill, though.