S3 hive style writes #697
Open
S3 hive style writes #697
+725
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpassos
commented
Mar 21, 2025
arthurpassos
commented
Mar 21, 2025
arthurpassos
commented
Mar 21, 2025
|
Depends on #700 |
arthurpassos
commented
Mar 24, 2025
and writing more tests are the only thing missing I guess |
…rt table function
arthurpassos
commented
Mar 27, 2025
|
This is an automated comment for commit abdd84a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
ianton-ru
reviewed
Mar 28, 2025
| throw Exception(ErrorCodes::LOGICAL_ERROR, "Table level partition expression and query level partition expression can't be specified together, this is a bug"); | ||
| } | ||
|
|
||
| static std::unordered_map<std::string, bool> partitioning_style_to_wildcard_acceptance = |
There was a problem hiding this comment.
Looks like a little bit overengineering. This make sense if we expect more variants in future.
There was a problem hiding this comment.
That's my assumption, do you think we could keep it or you want it to be changed?
| configuration->partitioning_style); | ||
| } | ||
|
|
||
| if (configuration->withPartitionWildcard() && !partitioning_style_to_wildcard_acceptance.at(configuration->partitioning_style)) |
There was a problem hiding this comment.
withPartitionWildcard method searches substring in strings on every call, better to call once and keep result in local variable.
| /// - https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html | ||
| /// - https://cloud.ibm.com/apidocs/cos/cos-compatibility#putobject | ||
|
|
||
| if (str.empty() || str.size() > 1024) |
There was a problem hiding this comment.
Just comment, not for change right now, because this code already exists, just moved in namespace, but I don't like it. As I understand key is generated inside clickhouse code and customer can't fully control key length. And when he gets this error - what's next? "Ok, key is to long, how can I fix it?".
May be we need to add task in TODO list to think about autodecreasing key length in cases like this.
There was a problem hiding this comment.
Not fully generated by ClickHouse. The key here represents the path without the bucket. Part of that can be specified by user upon table creation.
src/Storages/PartitionStrategy.cpp
Outdated
| */ | ||
| std::string formatToFileExtension(const std::string & format) | ||
| { | ||
| std::string lower_case_format; |
There was a problem hiding this comment.
What is the difference with just return Poco::toLower(format)?
There was a problem hiding this comment.
I'll use Poco::toLower
arthurpassos
commented
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info on ClickHouse#76802
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for hive partition style writes
Documentation entry for user-facing changes