Fixing clickhouse-ontime datasource. #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14472504053Details
💛 - Coveralls |
Slach
requested changes
Apr 15, 2025
| @@ -4,9 +4,10 @@ services: | |||
| environment: | |||
| - CLICKHOUSE_ALWAYS_RUN_INITDB_SCRIPTS=true | |||
| volumes: | |||
| - ./docker/clickhouse/load_ontime.sh:/docker-entrypoint-initdb.d/load_ontime.sh | |||
There was a problem hiding this comment.
hm when .sh stop works in initdb.d?
There was a problem hiding this comment.
default user restricted by 127.0.0.1 couple of months ago
let's add
environment CLICKHOUSE_SKIP_USER_SETUP=1 to docker-compose instead of change fast downloading ontime
There was a problem hiding this comment.
downloading data parts instead of inserting could be faster, but i'm not sure
Slach
approved these changes
Apr 15, 2025
| - /var/lib/clickhouse/ | ||
| - /var/log/clickhouse-server/ | ||
| - ./docker/clickhouse/init_schema_ontime.sql:/docker-entrypoint-initdb.d/init_schema.sql | ||
| - ./docker/clickhouse/users.xml:/etc/clickhouse-server/users.d/users.xml |
There was a problem hiding this comment.
maybe adding users.xml is better solution
|
ok. let's merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#763