Skip to content

Commit

Permalink
Fix setting signing delegation state (#1034)
Browse files Browse the repository at this point in the history
* fixes setting delegated status by inverting logic

* removes is
  • Loading branch information
cammiida authored Jan 15, 2025
1 parent 7e763b7 commit 2702061
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Altinn.App.Api/Controllers/SigningController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public async Task<IActionResult> GetSigneesState(
Name = signeeContext.PersonSignee?.DisplayName ?? signeeContext.OrganisationSignee?.DisplayName,
Organisation = signeeContext.OrganisationSignee?.DisplayName,
HasSigned = rnd.Next(1, 10) > 5, //TODO: When and where to check if signee has signed?
DelegationSuccessful = signeeContext.SigneeState.IsAccessDelegated is false,
DelegationSuccessful = signeeContext.SigneeState.IsAccessDelegated,
NotificationSuccessful =
signeeContext.SigneeState
is { SignatureRequestEmailSent: false, SignatureRequestSmsSent: false },
Expand Down
2 changes: 1 addition & 1 deletion src/Altinn.App.Core/Features/IInstanceDataMutator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface IInstanceDataMutator : IInstanceDataAccessor
/// Add a new data element without app logic to the instance.
/// </summary>
/// <remarks>
/// Saving to storage is not done until the instance is saved, so mutations to data might or might not be sendt to storage.
/// Saving to storage is not done until the instance is saved, so mutations to data might or might not be sent to storage.
/// </remarks>
BinaryDataChange AddBinaryDataElement(
string dataTypeId,
Expand Down

0 comments on commit 2702061

Please sign in to comment.